PYTHON-5905 - Make logging tests not fail due to PyPy GC issues#2934
Open
NoahStapp wants to merge 1 commit into
Open
PYTHON-5905 - Make logging tests not fail due to PyPy GC issues#2934NoahStapp wants to merge 1 commit into
NoahStapp wants to merge 1 commit into
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR updates the command-logging truncation tests to be resilient to extra structured command logs that can appear under PyPy due to non-deterministic garbage collection triggering cleanup commands during test execution.
Changes:
- Add a small helper (
_get_command_log) to select the structured log entry matching a specificcommandNameand command status. - Replace brittle
cm.records[N]indexing with filtered lookups for STARTED/SUCCEEDED/FAILED command logs in both sync and async logger tests.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| test/test_logger.py | Uses a helper to locate the intended command log records before asserting truncation lengths (sync tests). |
| test/asynchronous/test_logger.py | Mirrors the same robustness improvements for async logger tests. |
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PYTHON-5905
Changes in this PR
PyPy's GC is non-deterministic, so cleanup commands from earlier tests can pollute the logs. Fixes this issue by filtering for the specific command and status we want before asserting.
Test Plan
Test changes.
Checklist
Checklist for Author
[ ] Did you update the changelog (if necessary)?[ ] Is any followup work tracked in a JIRA ticket? If so, add link(s).Checklist for Reviewer