Skip to content

PYTHON-5713 Allow using OP_MSG exclusively#2799

Merged
sleepyStick merged 18 commits into
mongodb:masterfrom
sleepyStick:PYTHON-5713
Jun 8, 2026
Merged

PYTHON-5713 Allow using OP_MSG exclusively#2799
sleepyStick merged 18 commits into
mongodb:masterfrom
sleepyStick:PYTHON-5713

Conversation

@sleepyStick

@sleepyStick sleepyStick commented May 8, 2026

Copy link
Copy Markdown
Contributor

PYTHON-5713

Changes in this PR

  • handshake now always uses OP_MSG (and not OP_QUERY)
  • if server max wire version doesn't support OP_MSG, a ConfigurationError is raised

Test Plan

  • updated tests in test_handshake.py
  • added a new test for the ConfigurationError in test_handshake.py

Checklist

Checklist for Author

  • Did you update the changelog (if necessary)?
  • Is there test coverage?
  • Is any followup work tracked in a JIRA ticket? If so, add link(s).

Checklist for Reviewer

  • Does the title of the PR reference a JIRA Ticket?
  • Do you fully understand the implementation? (Would you be comfortable explaining how this code works to someone else?)
  • Is all relevant documentation (README or docstring) updated?

@sleepyStick sleepyStick mentioned this pull request May 8, 2026
Merged
4 tasks
@codecov-commenter

codecov-commenter commented May 8, 2026 •
edited
Loading

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 96.82540% with 2 lines in your changes missing coverage. Please review.

Files with missing lines Patch % Lines
pymongo/asynchronous/cursor.py 92.30% 0 Missing and 1 partial ⚠️
pymongo/synchronous/cursor.py 92.30% 0 Missing and 1 partial ⚠️

📢 Thoughts on this report? Let us know!

sleepyStick and others added 17 commits May 8, 2026 13:49
@sleepyStick
Merge branch 'master' into PYTHON-5713
d310dd6
@sleepyStick
Merge branch 'master' into PYTHON-5713
fb58e0e
@sleepyStick
address JY review comments on spec PR
1686866
@sleepyStick
oops accidentally removed the await -- made changes to sync and copy …
148e913 
…pasted them back to async *facepalm*
@sleepyStick
remove opquery opreply and propagate original error to user
921f29d
@sleepyStick
remove dead code / fix typing tests
8e2f358
@sleepyStick
remove opreply from test
664ece1
@sleepyStick
Merge branch 'master' into PYTHON-5713
7f4b266
@sleepyStick
add unified test?
9b0cb2e
@sleepyStick
wait do the unified tests need to be pulled out to run? 🤔
2a17752
@sleepyStick
Merge branch 'master' into PYTHON-5713
36cb287
@sleepyStick
fix typing and remove opreply after merge
f8f5fc8
@sleepyStick
rename test file
08ba167
@sleepyStick
remove op_msg booleans / params
0c2facd
@sleepyStick
Merge branch 'master' into PYTHON-5713
aec68a1
@sleepyStick
remove op_reply after merging
50f73b5
@sleepyStick
fix typing errors
49e59e5
@sleepyStick sleepyStick marked this pull request as ready for review June 8, 2026 18:50
@sleepyStick sleepyStick requested a review from a team as a code owner June 8, 2026 18:50
@sleepyStick sleepyStick requested a review from sophiayangDB June 8, 2026 18:50
blink1073
blink1073 approved these changes Jun 8, 2026
View reviewed changes

@blink1073 blink1073 left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@sleepyStick sleepyStick merged commit e9058e3 into mongodb:master Jun 8, 2026
87 of 89 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@blink1073 blink1073 blink1073 approved these changes

@sophiayangDB sophiayangDB Awaiting requested review from sophiayangDB sophiayangDB is a code owner automatically assigned from mongodb/dbx-python

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@sleepyStick @codecov-commenter @blink1073