Skip to content

Clean up ended streams to free leaked memory #200

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
argon wants to merge 8 commits into
base: master
Choose a base branch
from
Open

Clean up ended streams to free leaked memory #200

Changes from 1 commit
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
e4fdf71
Cleanup ended streams to free memory
argon May 1, 2016
a7f1e30
Handle server streams correctly
argon May 1, 2016
9e36236
Fix style issues
argon May 1, 2016
9e81bd5
Update connection.js
simllll Oct 20, 2016
5421660
Update connection.js
simllll Oct 20, 2016
aec8aaa
Merge pull request #1 from simllll/master
florianreinhart Nov 8, 2016
074a654
Remove invalid assert
thughes Mar 7, 2017
dff41d9
Fix GOAWAY deserialization when debug data is present
thughes Mar 7, 2017
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Remove invalid assert 
Fixes #228

In the case where this._push(frame) returns null (i.e., the frame is too
large for the window and split or the window size is <=0), moreNeeded
will be set to null. Then this._queue.push(frame) is called, but
moreNeeded is still null. Thus, any time the window is <=0 or the frame
is split we'll hit the assert:

  var moreNeeded = null;
  if (this._queue.length === 0) {
    moreNeeded = this._push(frame);
  }

  if (moreNeeded === null) {
    this._queue.push(frame);
  }

  return moreNeeded;

Credit goes to @jrabek for original version of this patch
  • Loading branch information
@thughes @florianreinhart
thughes authored and florianreinhart committed Mar 15, 2017
commit 074a654024a508b7f7110673c79a7fa72a894d2c
3 changes: 1 addition & 2 deletions lib/protocol/connection.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -340,8 +340,7 @@ priority_loop:
var moreNeeded = this.push(frame);
this._changeStreamCount(frame.count_change);

assert(moreNeeded !== null); // The frame shouldn't be unforwarded
if (moreNeeded === false) {
if (!moreNeeded) {
break priority_loop;
}
}
Expand Down