Skip to content

Forward endpoint errors to httpsRequest #185

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
felicienfrancois wants to merge 5 commits into
base: master
Choose a base branch
from
Open

Forward endpoint errors to httpsRequest #185

Changes from 1 commit
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
6c90a7e
Forward endpoint errors to httpsRequest
felicienfrancois Mar 2, 2016
bd4a034
Forward stream errors to request
felicienfrancois Mar 6, 2016
804477a
Forward stream errors to response
felicienfrancois Mar 6, 2016
19dfc70
fix stream mocks
felicienfrancois Mar 6, 2016
314cffd
Add logging to stream and endpoint error forwarding
felicienfrancois Apr 23, 2016
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
fix stream mocks
  • Loading branch information
@felicienfrancois
felicienfrancois committed Mar 6, 2016
commit 19dfc70294d23fd745b4848b276bed175085cd42
4 changes: 2 additions & 2 deletions test/http.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -186,14 +186,14 @@ describe('http.js', function() {
} else {
called = true;
}
}, once: util.noop };
}, once: util.noop, on: util.noop };
var response = new http2.OutgoingResponse(stream);

response.writeHead(200);
response.writeHead(404);
});
it('field finished should be Boolean', function(){
var stream = { _log: util.log, headers: function () {}, once: util.noop };
var stream = { _log: util.log, headers: function () {}, once: util.noop, on: util.noop };
var response = new http2.OutgoingResponse(stream);
expect(response.finished).to.be.a('Boolean');
});
Expand Down