Allow chaining for Server.listen and Server.on#168
Merged
Conversation
(and to be conform with http and https API, see https://nodejs.org/api/http.html#http_server_listen_port_hostname_backlog_callback)
(and to be conform with http and https API, see https://nodejs.org/api/http.html#http_server_listen_port_hostname_backlog_callback)
PhilippSoehnlein
added a commit
to PhilippSoehnlein/grunt-contrib-connect
that referenced
this pull request
Jan 14, 2016
(depends on molnarg/node-http2#168; If PR isn't accepted there, the server.listen().on().on() must be split into three statements without chaining.)
|
ping @nwgh |
PhilippSoehnlein
added a commit
to PhilippSoehnlein/grunt-contrib-connect
that referenced
this pull request
Jan 19, 2016
(Because it looks like molnarg/node-http2#168 needs some time.)
nwgh
added a commit
that referenced
this pull request
Jan 28, 2016
Allow chaining for Server.listen and Server.on
Collaborator
|
Thanks! |
Contributor
Author
|
@nwgh For when is the next release planned? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
node-http2 behaves differently compared to the standard node http- and https-API when it comes to the return value of
Server.listen()andServer.on().This PR adapts the behavior of the original node APIs.