Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: molnarg/node-http2
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: master
Choose a base ref
...
head repository: molnarg/node-http2
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: close-stream-3
Choose a head ref
Checking mergeability… Don’t worry, you can still create the pull request.
  • 6 commits
  • 9 files changed
  • 1 contributor

Commits on Aug 28, 2014

  1. Proxy the 'listening' event from the underlying server

    @snorp
    snorp committed Aug 28, 2014
    Configuration menu
    Copy the full SHA
    9d4279e View commit details
    Browse the repository at this point in the history

  2. Un-revert the close stream work that was reverted in node-http2-protocol 

    This reverts a03dff630a33771d045ac0362023afb84b441aa4 from node-http2-protocol
    @snorp
    snorp committed Aug 28, 2014
    Configuration menu
    Copy the full SHA
    a147f2f View commit details
    Browse the repository at this point in the history

  3. Revert "Revert "HTTP - forwarding error and close events from streams… 

    … to req and res objects""

This reverts commit 5252939.
    @snorp
    snorp committed Aug 28, 2014
    Configuration menu
    Copy the full SHA
    82cdba5 View commit details
    Browse the repository at this point in the history

  4. Add tests for response closing when the socket goes away

    @snorp
    snorp committed Aug 28, 2014
    Configuration menu
    Copy the full SHA
    8ae50db View commit details
    Browse the repository at this point in the history

  5. Don't try to write into closed streams

    @snorp
    snorp committed Aug 28, 2014
    Configuration menu
    Copy the full SHA
    74232ec View commit details
    Browse the repository at this point in the history

Commits on Sep 2, 2014

  1. Fix 'close' event behavior 

    This fixes things so we emit 'close' only when it's an unexpected thing. Otherwise
'end' or 'finish' indicates normal termination.

See http://nodejs.org/api/http.html#http_event_close_1
as well as http://nodejs.org/api/http.html#http_event_close_2
    @snorp
    snorp committed Sep 2, 2014
    Configuration menu
    Copy the full SHA
    48d2ea4 View commit details
    Browse the repository at this point in the history
Loading