fix: forward Error.cause in SdkError constructor - #2663
Open
anshusaurav wants to merge 1 commit into
Open
Conversation
…l#2657) SdkError's third parameter is `data`, not `ErrorOptions`, so `classifyNetworkError`'s `{ cause: error }` landed in `data` instead of `Error.cause`. This broke standard cause-chain walking used by loggers (pino) and error trackers (Sentry). Add an `options?: ErrorOptions` parameter to both `SdkError` and `SdkHttpError` constructors, forwarding it to `super()`. Fix the call site in `classifyNetworkError` to pass the underlying error as `options.cause` rather than as `data`.
|
@modelcontextprotocol/client
@modelcontextprotocol/codemod
@modelcontextprotocol/core
@modelcontextprotocol/server
@modelcontextprotocol/server-legacy
@modelcontextprotocol/express
@modelcontextprotocol/fastify
@modelcontextprotocol/hono
@modelcontextprotocol/node
commit: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #2657.
SdkError's third constructor parameter isdata, notErrorOptions, so whenclassifyNetworkErrorpassed{ cause: error }it landed inerror.data.causeinstead oferror.cause. This broke standard cause-chain walking used by loggers (pino) and error trackers (Sentry) — the chain terminated atSdkErrorinstead of reaching the root network error.Changes
SdkErrorconstructor: added an optionaloptions?: ErrorOptionsparameter (4th arg), forwarded tosuper(message, options). Fully backward-compatible — existing 2- and 3-arg call sites are unaffected.SdkHttpErrorconstructor: same treatment, forwardingoptionsthrough tosuper().classifyNetworkError: moved{ cause: error }from thedataslot to the newoptionsparameter so the underlying network error is reachable via the standarderror.causeproperty.probeAuthSeam.test.tsassertion updated fromerror.data.causetoerror.cause.Test plan
sdkErrorCause.test.tsverifying:SdkErrorforwards cause toError.causewhen passed via optionsdataandcauseremain independent when both are providedcauseisundefinedwhen options are omitted (backward compat)SdkHttpErrorforwards cause through the inheritance chainprobeAuthSeam.test.tsupdated and passingpnpm typecheck:allpassespnpm build:allpassespnpm lint:allpasses (after prettier formatting)