StreamableHttp - update docs - #664
Merged
Merged
Conversation
ihrpr
marked this pull request as ready for review
May 8, 2025 11:31
bhosmer-ant
previously approved these changes
May 8, 2025
bhosmer-ant
left a comment
Contributor
There was a problem hiding this comment.
LGTM! Couple v minor ideas inline but feel free to ignore
|
|
||
| ### Mounting to an Existing ASGI Server | ||
|
|
||
| > **Note**: SSE transport is being superseded by streamable HTTP transport. Consider using streamable HTTP for production deployments. |
Contributor
There was a problem hiding this comment.
fwiw the wording here is slightly different from the prior note
| asyncio.run(run()) | ||
| ``` | ||
|
|
||
| Clients can also connect using streamable HTTP transport: |
Contributor
There was a problem hiding this comment.
idk does this deserve its own section header?
Contributor
There was a problem hiding this comment.
the "how should I decide what transport my client should use" noob question might come to mind here - if there's somewhere else in the docs where we cover this, it might be a nice thing to link to
ihrpr
dismissed stale reviews from bhosmer-ant and jerome3o-anthropic
May 8, 2025 19:43
The base branch was changed.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Updating docs before the release