Skip to content

fix(mcpserver): emit one TextContent block when a tool returns an empty list (issue #3305) - #3319

Open
gingeekrishna wants to merge 2 commits into
modelcontextprotocol:mainfrom
gingeekrishna:fix/3305-empty-list-zero-content-blocks
Open

fix(mcpserver): emit one TextContent block when a tool returns an empty list (issue #3305)#3319
gingeekrishna wants to merge 2 commits into
modelcontextprotocol:mainfrom
gingeekrishna:fix/3305-empty-list-zero-content-blocks

Conversation

@gingeekrishna

Copy link
Copy Markdown

Summary

  • When a tool returns an empty list or tuple, _convert_to_content previously produced zero content blocks, making "no results" indistinguishable from "call produced nothing" for clients reading unstructured content.
  • Fix: when the per-item flattening produces no blocks, emit a single TextContent whose text is the JSON-serialised empty collection ([] for both list and tuple).
  • All non-empty paths are byte-identical to the previous behaviour. structuredContent is unaffected in all cases.

Root cause

_convert_to_content (src/mcp/server/mcpserver/utilities/func_metadata.py:563) flattens a list by chaining the conversion of each item:

if isinstance(result, list | tuple):
    return list(chain.from_iterable(_convert_to_content(item) for item in result))

With zero items there is nothing to concatenate, so the result is []. The same "empty" answer then behaves differently depending on return type:

tool returns content blocks text seen by model
[] 0 (broken) ''
[{...}, {...}] 2 both items
"" 1 ''

Fix

if isinstance(result, list | tuple):
    items = list(chain.from_iterable(_convert_to_content(item) for item in result))
    if not items:
        return [TextContent(type="text", text=json.dumps(list(result)))]
    return items

Tests added

Four new tests in tests/server/mcpserver/test_func_metadata.py:

  • test_empty_list_produces_one_text_content_block — core fix for list
  • test_empty_tuple_produces_one_text_content_block — same guarantee for tuple
  • test_non_empty_list_content_blocks_unchanged — non-empty path is byte-identical
  • test_empty_list_structured_content_unaffectedstructuredContent still correct

All 46 tests in the file pass.

Test plan

  • uv run --frozen pytest tests/server/mcpserver/test_func_metadata.py — 46/46 pass
  • Confirm a tool returning [] now delivers one content block with text "[]" to the model
  • Confirm existing tools returning non-empty lists are unaffected

Closes #3305

…ty list

A tool annotated to return list[T] that actually returns [] was
converted to zero content blocks by _convert_to_content, because the
chain.from_iterable() flattening of an empty iterable is []. For a
client reading unstructured content 'no matches' was indistinguishable
from 'the call produced nothing', causing LLMs to retry the same lookup
indefinitely.

The fix: when the per-item conversion of a list/tuple produces no
content blocks, fall back to a single TextContent whose text is the
JSON-serialised empty collection ([] for both list and tuple). All
non-empty paths are byte-identical to the previous behaviour.

structuredContent is populated correctly in all cases and is unaffected.

Closes modelcontextprotocol#3305

Signed-off-by: Radha Krishnan P <gingeekrishna@gmail.com>
Copilot AI lite review requested due to automatic review settings August 16, 2026 16:06

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot was unable to review this pull request because the user who requested the review has reached their quota limit.

@cubic-dev-ai cubic-dev-ai Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All reported issues were addressed across 2 files

Reply with feedback, questions, or to request a fix.

Re-trigger cubic

Comment thread src/mcp/server/mcpserver/utilities/func_metadata.py Outdated
Co-authored-by: cubic-dev-ai[bot] <191113872+cubic-dev-ai[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

A tool returning an empty list produces a CallToolResult with zero content blocks

2 participants