Preserve exception chains with raise ... from - #3312
Open
syahra712 wants to merge 1 commit into
Open
Conversation
Add `from` clause to 11 raise statements that re-raise a new exception after catching another, preserving the original traceback and __cause__ for debugging. Follows the pattern established in modelcontextprotocol#2542 for the remaining sites. Fixes modelcontextprotocol#2564
2 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
fromclause to 11raisestatements that catch one exception and raise another, preserving the original traceback and__cause__from, Python shows "During handling of the above exception, another exception occurred" instead of "The above exception was the direct cause of the following exception", and callers cannot inspect__cause__to determine the root cause programmaticallyFiles changed
client/session.pySchemaError→RuntimeErrorclient/auth/utils.pyValidationError→OAuthTokenErrorserver/auth/middleware/client_auth.pyValueError/UnicodeDecodeError/binascii.Error→AuthenticationErrorserver/mcpserver/resources/types.pyException→ValueError(4 sites)server/mcpserver/server.pyResourceNotFoundError→MCPError,ResourceError→MCPErrorserver/mcpserver/prompts/base.pyException→ValueErrorRelated issue
Fixes #2564
Verification
from e/from err/from excto existingraisestatementsmain(resource_manager.py, templates.py, resolve.py); this PR covers the remaining 11