fix(auth): normalize resource path dot-segments - #3308
Open
SarathChandraBellam wants to merge 2 commits into
Open
fix(auth): normalize resource path dot-segments#3308SarathChandraBellam wants to merge 2 commits into
SarathChandraBellam wants to merge 2 commits into
Conversation
SarathChandraBellam
marked this pull request as ready for review
August 14, 2026 07:25
There was a problem hiding this comment.
All reported issues were addressed across 2 files
Reply with feedback, questions, or to request a fix.
Re-trigger cubic
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
%2F.Fixes #3303
Why
check_resource_allowed()previously used a directstartswith()comparison after only trailing-slash normalization. A requested resource such as/api/../admincould therefore pass a check configured for/api, even though it resolves outside the configured resource.The implementation decodes only encoded dots (
%2e), rather than fully unquoting the path. It then applies RFC-style dot-segment removal without collapsing empty path segments, so repeated separators remain significant. This avoids both path traversal and accidental widening of a resource boundary such as/api//.Validation
pytest tests/shared/test_auth_utils.py -q— 19 passedAI assistance was used during investigation and implementation; I reviewed the resulting code and tests myself.