perf(client): cache compiled jsonschema validator per tool output schema Fixes #3133#3157
Open
SpiliosDimakopoulos wants to merge 1 commit into
Conversation
validate_tool_result() called jsonschema.validate() on every tools/call, which rebuilds the validator class, re-checks the schema, and re-crawls its \ each time — even though a tool's output schema doesn't change between calls. Cache the compiled validator per tool name instead, and invalidate the cache when list_tools() reports a changed schema for that tool. Error message selection (best_match) is unchanged. Fixes modelcontextprotocol#3133
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.