Fix SSE gateway endpoint resolution#2959
Draft
nZiben wants to merge 1 commit into
Draft
Conversation
4085ff2 to
5f0974f
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #795.
Summary
This updates the SSE client endpoint resolution logic for API-gateway and nested-route deployments.
Previously,
sse_clientusedurljoin(url, sse.data)for endpoint events. If the public SSE URL included a gateway prefix and the server emitted an absolute endpoint path, Python treated the endpoint as origin-rooted and dropped the gateway prefix.For example:
previously resolved to:
The new resolver preserves the non-overlapping public prefix when the SSE URL path and endpoint path overlap:
It intentionally keeps standard root-relative behavior for no-overlap absolute paths such as
/messages, because those are ambiguous: the client cannot safely infer whether the endpoint should be rooted at the origin or under a gateway prefix. Server-side mount-prefix cases should continue to be handled through ASGIroot_path.Verification
uv run --frozen pytest tests/shared/test_sse.py -quv run --frozen ruff format --check src/mcp/client/sse.py tests/shared/test_sse.pyuv run --frozen ruff check src/mcp/client/sse.py tests/shared/test_sse.pyuv run --frozen pyright src/mcp/client/sse.py tests/shared/test_sse.pysrc/mcp/client/sse.py: 100%UV_FROZEN=1 uv run --frozen strict-no-cover./scripts/test