fix: omit null optional fields from task result payloads#2809
Open
liuzemei wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #2539.
Task result delivery was serializing completed task payloads with
model_dump(by_alias=True), which preserved optionalNonefields as JSONnullinside nested content blocks. This can maketasks/resultresponses fail clients that treat those fields as optional-but-not-null.This updates the task result handler to dump payloads with
mode="json"andexclude_none=True, matching the session serialization path, while still adding the required related-task metadata.Tests
.venv/bin/python -m pytest -q tests/experimental/tasks/server/test_task_result_handler.py::test_handle_omits_none_fields_from_completed_task_payload.venv/bin/python -m compileall -q src/mcp/server/experimental/task_result_handler.py tests/experimental/tasks/server/test_task_result_handler.py && git diff --check.venv/bin/python -m pytest -q tests/experimental/tasks/server/test_task_result_handler.py.venv/bin/python -m pytest -q tests/experimental/tasks/server.venv/bin/ruff check src/mcp/server/experimental/task_result_handler.py tests/experimental/tasks/server/test_task_result_handler.py && .venv/bin/ruff format --check src/mcp/server/experimental/task_result_handler.py tests/experimental/tasks/server/test_task_result_handler.py