[Server] Log filesystem failures in FileSessionStore - #488
Open
chr-hertel wants to merge 2 commits into
Open
Conversation
chr-hertel
requested review from
CodeWithKyrian,
Nyholm and
soyuka
as code owners
August 29, 2026 08:31
Contributor
There was a problem hiding this comment.
🟡 Changes recommended
GC still reports failed session-file deletions as successful without logging them.
Once you've addressed the issues Copilot identified, you can request another Copilot review.
Pull request overview
Adds PSR-3 warning logs for filesystem failures in FileSessionStore.
Changes:
- Injects an optional logger with
NullLoggerfallback. - Logs directory, read, write, move, deletion, and GC-open failures.
- Adds warning and happy-path tests.
File summaries
| File | Description |
|---|---|
src/Server/Session/FileSessionStore.php |
Adds filesystem failure logging. |
tests/Unit/Server/Session/FileSessionStoreTest.php |
Tests selected warning paths. |
Review details
- Files reviewed: 2/2 changed files
- Comments generated: 1
- Review effort level: Balanced
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
|
|
||
| $dir = @opendir($this->directory); | ||
| if (false === $dir) { | ||
| $this->logger->warning('Failed to open session directory for garbage collection.', [ |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
FileSessionStorenow takes an optional PSR-3 logger (defaulting toNullLogger, matching the SDK convention) and warns when a filesystem operation fails in a way that loses data: failedmkdir, session file read/write/move failures, failed unlinks, andopendirfailure during GC.Benign race suppressions (e.g.
filemtimeon a concurrently deleted file) keep their@.