[Server] Fix StreamableHttpTransport mutable state and clock - #487
Open
chr-hertel wants to merge 1 commit into
Open
[Server] Fix StreamableHttpTransport mutable state and clock#487chr-hertel wants to merge 1 commit into
chr-hertel wants to merge 1 commit into
Conversation
chr-hertel
requested review from
CodeWithKyrian,
Nyholm and
soyuka
as code owners
August 29, 2026 08:31
Contributor
There was a problem hiding this comment.
🟢 Approval recommended
The focused changes are consistent with existing patterns and adequately covered by regression tests.
Pull request overview
Fixes stale transport state and makes timeout behavior deterministic and testable.
Changes:
- Consumes immediate responses once and preserves the original request.
- Injects a PSR clock for pending-request timeout checks.
- Adds regression tests for response replay and clock-driven timeout handling.
File summaries
| File | Description |
|---|---|
src/Server/Transport/StreamableHttpTransport.php |
Corrects state handling, request threading, and timeout clock usage. |
tests/Unit/Server/Transport/StreamableHttpTransportTest.php |
Covers response consumption and injected-clock timeout behavior. |
Review details
- Files reviewed: 2/2 changed files
- Comments generated: 0
- Review effort level: Balanced
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
handlePostRequest(), so a reused transport instance no longer replays the first POST's response.$this->requestis no longer reassigned mid-flight; the middleware-processed request is threaded as a parameter and the property is nowreadonly.ClockInterfaceis injected (defaultNativeClock, matching the session stores) and used for pending-request timeouts, making the polling loop's timeout testable without a 120s sleep.The echo/flush SSE body in
CallbackStreamis left as-is — it is inherent to theCallbackStreamdesign and out of scope here.