[Schema] Fix _meta guard key in Request and Notification jsonSerialize() - #485
Open
chr-hertel wants to merge 1 commit into
Open
[Schema] Fix _meta guard key in Request and Notification jsonSerialize()#485chr-hertel wants to merge 1 commit into
chr-hertel wants to merge 1 commit into
Conversation
chr-hertel
requested review from
CodeWithKyrian,
Nyholm and
soyuka
as code owners
August 29, 2026 08:31
Contributor
There was a problem hiding this comment.
🟢 Approval recommended
The focused fix matches the intended behavior and is covered by regression tests.
Pull request overview
Corrects JSON-RPC metadata precedence so class-provided _meta values are preserved.
Changes:
- Fixes
_metaguards in request and notification serialization. - Adds regression coverage for both message types.
File summaries
| File | Description |
|---|---|
src/Schema/JsonRpc/Request.php |
Checks the correct metadata key. |
src/Schema/JsonRpc/Notification.php |
Checks the correct metadata key. |
tests/Unit/Schema/JsonRpc/RequestTest.php |
Tests request metadata precedence. |
tests/Unit/Schema/JsonRpc/NotificationTest.php |
Tests notification metadata precedence. |
Review details
- Files reviewed: 4/4 changed files
- Comments generated: 0
- Review effort level: Balanced
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The guard in
Request::jsonSerialize()checked$params['meta']while the write targets$params['_meta'], so a_metaprovided by the message class was silently overwritten bywithMeta().Fixes the key in both
RequestandNotification, with a regression test each.