[Server] Stop Session::forget() from creating missing segments - #484
Open
chr-hertel wants to merge 1 commit into
Open
[Server] Stop Session::forget() from creating missing segments#484chr-hertel wants to merge 1 commit into
chr-hertel wants to merge 1 commit into
Conversation
chr-hertel
requested review from
CodeWithKyrian,
Nyholm and
soyuka
as code owners
August 29, 2026 08:31
Contributor
There was a problem hiding this comment.
🟢 Approval recommended
The focused implementation correctly resolves the mutation bug and includes appropriate regression coverage.
Pull request overview
Prevents Session::forget() from creating or overwriting intermediate path segments when a nested key is absent.
Changes:
- Return early when an intermediate segment is missing or non-array.
- Add regression tests for both scenarios.
File summaries
| File | Description |
|---|---|
src/Server/Session/Session.php |
Safely aborts deletion for invalid intermediate paths. |
tests/Unit/Server/Session/SessionTest.php |
Covers missing and non-array intermediate segments. |
Review details
- Files reviewed: 2/2 changed files
- Comments generated: 0
- Review effort level: Balanced
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Session::forget()reusedset()'s loop body, so deleting a nested key vivified missing intermediate segments:forget('a.b')lefta => []behind, and a non-array intermediate got clobbered into an array. It now returns early when the path doesn't exist.Regression tests included.