Notification to cancel a previous request#47
Merged
Conversation
dsp-ant
approved these changes
Nov 14, 2024
jspahrsummers
added a commit
that referenced
this pull request
Mar 12, 2025
fix: typo in prompts.mdx
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We'll need to implement some reasonable timeouts in our SDKs, in order to prevent requests from hanging forever due to misbehavior on the remote side, but when a timeout occurs, we ideally want some way to signal that as well.
This PR introduces the concept of a cancellation notification, issued to indicate that a previous request (one that SHOULD still be in-flight) is being cancelled by its issuer and the result will be ignored. The recipient can use this to interrupt any processing that's still happening, if applicable.
Resolves #10 (I think by being a better solution than timeouts defined in messages).