Skip to content

Notification to cancel a previous request#47

Merged
jspahrsummers merged 2 commits into
mainfrom
justin/timeouts
Nov 14, 2024
Merged

Notification to cancel a previous request#47
jspahrsummers merged 2 commits into
mainfrom
justin/timeouts

Conversation

@jspahrsummers
Copy link
Copy Markdown
Member

@jspahrsummers jspahrsummers commented Nov 14, 2024

We'll need to implement some reasonable timeouts in our SDKs, in order to prevent requests from hanging forever due to misbehavior on the remote side, but when a timeout occurs, we ideally want some way to signal that as well.

This PR introduces the concept of a cancellation notification, issued to indicate that a previous request (one that SHOULD still be in-flight) is being cancelled by its issuer and the result will be ignored. The recipient can use this to interrupt any processing that's still happening, if applicable.

Resolves #10 (I think by being a better solution than timeouts defined in messages).

@jspahrsummers jspahrsummers merged commit 795ecef into main Nov 14, 2024
@jspahrsummers jspahrsummers deleted the justin/timeouts branch November 14, 2024 13:18
jspahrsummers added a commit that referenced this pull request Mar 12, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Allow specifying timeouts for most operations

2 participants