fix: automation staleness - #3241
Open
mateolafalce wants to merge 2 commits into
Open
Conversation
Reuse the original staleness analysis when recording successful actions and wait for summary updates before returning. Co-authored-by: Michael <265398295+lafalce-assistant@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix SEP automation summaries by preserving the original staleness analysis after an action is executed and awaiting summary updates before processing completes.
Motivation and Context
Staleness actions can modify an SEP—for example, by adding a bot comment—which changes its latest activity. Re-analyzing the SEP afterward could therefore produce different staleness data and omit or misrepresent successful actions in the final summary.
This change reuses the analysis that triggered the action, ensuring summaries retain the original activity age, ping target, and close decision. It also waits for asynchronous summary updates before returning.
How Has This Been Tested?
Ran the complete SEP automation unit test suite:
npm testAll 7 test files and 41 tests passed.
Added regression tests covering:
Breaking Changes
None.
Types of changes
Checklist
Additional context
The processor now carries the original
StaleAnalysisalongside the action result instead of invoking the analyzer again after the action. This also avoids an unnecessary second GitHub comments lookup.