schema(draft): align subscriptions/listen with envelope and _meta naming conventions#3006
Open
JaynouOliver wants to merge 1 commit into
Conversation
…ing conventions Fixes modelcontextprotocol#2989 Rename SubscriptionsListenResultMeta to SubscriptionsListenResultMetaObject to match the MetaObject-suffix convention used by MetaObject, RequestMetaObject, and NotificationMetaObject, and add the SubscriptionsListenResultResponse envelope so subscriptions/listen matches the per-method *ResultResponse pattern used by the other nine request methods. Adds a listen-closed-response.json example validated against the new envelope. schema.json and schema.mdx are regenerated.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #2989
Summary
Two consistency fixes in the draft schema for the
subscriptions/listentypes added in #2953, aligning them with the conventions established by the surrounding code:SubscriptionsListenResultMeta→SubscriptionsListenResultMetaObject. The other_meta-contents types (MetaObject,RequestMetaObject,NotificationMetaObjectfrom Align draft schema with spec docs (subscriptionId, HeaderMismatch, notification directions) #2889) all use theMetaObjectsuffix; this was the one divergence.SubscriptionsListenResultResponseenvelope. Every other request method has a dedicated*ResultResponseenvelope (CallToolResultResponse,DiscoverResultResponse,ReadResourceResultResponse, etc.);subscriptions/listenwas the only one without. Also adds alisten-closed-response.jsonexample, which validates against the new envelope.Since these are draft-only (unreleased) editorial changes with no wire-format impact, no SEP should be needed. If either half turns out to be intentional as-is (per the questions in #2989), happy to drop that half — the two changes are independent.
schema.jsonanddocs/specification/draft/schema.mdxare regenerated vianpm run generate:schema.Verification