fix(schema): extract ElicitationCompleteNotificationParams to extend NotificationParams#2866
Open
clouatre wants to merge 1 commit into
Conversation
…NotificationParams Signed-off-by: Hugues Clouâtre <hugues@linux.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
ElicitationCompleteNotificationwas the only notification in the schema whoseparamswas an anonymous inline object. Every other notification (CancelledNotification,ProgressNotification,ResourceUpdatedNotification,LoggingMessageNotification,SubscriptionsAcknowledgedNotification) uses a named*NotificationParamsinterface that extendsNotificationParams.This extracts
ElicitationCompleteNotificationParams extends NotificationParamsand wires it intoElicitationCompleteNotification, restoring consistency and ensuring the universal_metafield is inherited.Changes
schema/draft/schema.ts: addElicitationCompleteNotificationParamsinterface beforeElicitationCompleteNotificationschema/draft/schema.json: regenerated vianpm run generate:schemadocs/specification/draft/schema.mdx: regenerated vianpm run generate:schemaTesting
npm run check:schemapasses clean (TypeScript, ESLint, Prettier, JSON validation, 127 examples)Closes #2651