fix: NumberSchema min/max/default should be number, not integer#2710
Open
gsdv wants to merge 1 commit into
Open
fix: NumberSchema min/max/default should be number, not integer#2710gsdv wants to merge 1 commit into
gsdv wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #2698
Motivation and Context
In
NumberSchema, fieldsminimum,maximum, anddefaultare declared asnumberin the TypeScript source, but the generatedschema.jsonoutputs them as"type": "integer". This is wrong, as aNumberSchemawhosetypeis"number"must accept non-integer values for its bounds and default.Root cause:
scripts/generate-schemas.tsinvokestypescript-json-schemawith--defaultNumberType integer, which makes every TSnumberserialize as JSONintegerunless the field opts out. TheNumberSchemafields do not have opt-out annotation.The fix uses the same
@TJS-type numberJSDoc escape hatch already used elsewhere in the schema (like inProgressNotification.progress).How Has This Been Tested?
Ran
npm run generate:schemaand confirmed the JSON diff is exactly integer to number for the three fields in both draft and 2025-11-25.npm run check:schemapasses.Breaking Changes
No breaking changes, source types are unchanged. The JSON schema is now more permissive, accepting non-integer values for
minimum,maximum, anddefault. The previous rejecting of non-integer values was incorrect.Types of changes
Checklist
Additional context
AI assistance disclosure
I had Claude Code help me confirm the fix was correct.