-
Notifications
You must be signed in to change notification settings - Fork 1.7k
SEP-2350: Clarify client-side scope accumulation in step-up authorization #2350
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
+60
−9
Merged
Changes from all commits
Commits
Show all changes
5 commits
Select commit
Hold shift + click to select a range
48164f3
docs: clarify client-side scope accumulation in step-up authorization
dend db9367d
docs: add hierarchical scope note to step-up authorization flow
localden d5213f4
Merge branch 'main' into den/scopes
localden 4325a78
Add guidance against incremental scope challenging within a single op…
localden 029482b
Merge branch 'main' into den/scopes
localden File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why are they not required? This seems like a great way to enable constant AS thrashing.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The thrashing mitigation lives on the client side. Step 2 of the step-up flow requires clients to compute the union of previously requested scopes and the newly challenged scopes before re-authorizing, and clients SHOULD implement retry limits. So a well-behaved client hits the AS once per new scope requirement, not once per operation.
We can't make server-side union a MUST because servers often can't provide it reliably:
In RFC 6750 Section 3.1, the doc defines the scope attribute as "the scope necessary to access the requested resource," which is a per-request statement. The client is the only party with ground truth on what's already requested, so that's where accumulation belongs.
Servers that can compute the union are free to do so (the "extended approach" a few lines down covers this). We're just not mandating statefulness that a large class of servers can't deliver.