Remove deprecated taskId from cancellation notification - #1833
Merged
localden merged 4 commits intoNov 20, 2025
Conversation
Contributor
|
lgtm, nice clean up. |
000-000-000-000-000
approved these changes
Nov 20, 2025
This was referenced Nov 21, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
During #1732, task cancellation was moved from
notifications/cancelledto a newtasks/cancelrequest. ThetaskIdadded tonotifications/cancelledwas incorrectly immediately deprecated instead of removed.Motivation and Context
How Has This Been Tested?
Breaking Changes
Types of changes
Checklist
Additional context