Add missing Export-Package to mcp-json-jackson2 and mcp-json-jackson3#911
Open
joaodinissf wants to merge 1 commit intomodelcontextprotocol:mainfrom
Open
Add missing Export-Package to mcp-json-jackson2 and mcp-json-jackson3#911joaodinissf wants to merge 1 commit intomodelcontextprotocol:mainfrom
joaodinissf wants to merge 1 commit intomodelcontextprotocol:mainfrom
Conversation
Use explicit package names instead of a wildcard glob to avoid embedding mcp-core classes into the jackson module JARs. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add explicit
Export-Packagedirectives to the jackson modules so OSGi consumers can access classes directly.Motivation and Context
PR #779 added bnd configuration to the jackson modules but omitted
Export-Package(whichmcp-corehas). Without it, all packages are bundle-private, which prevents direct instantiation ofJacksonMcpJsonMapperSupplierorDefaultJsonSchemaValidatorfrom other bundles — the recommended workaround per #562 sinceServiceLoader.load()does not work across OSGi bundle boundaries.This particularly affects Eclipse PDE and Tycho-based projects, which get compile-time "Access restriction" errors and runtime
ClassNotFoundExceptionwhen referencing classes from these modules.How Has This Been Tested?
Verified the generated
META-INF/MANIFEST.MFaftermvn process-classescontains the correctExport-Packageheader with only the module's own packages. Also tested in an Eclipse PDE project — the patched modules compile and resolve without issues.Breaking Changes
No.
Types of changes
Checklist
🤖 Generated with Claude Code