docs: explain node import swallowing error#5401
Merged
JoshuaKGoldberg merged 1 commit intomochajs:mainfrom Jul 15, 2025
Merged
Conversation
|
|
JoshuaKGoldberg
requested changes
Jul 10, 2025
Member
JoshuaKGoldberg
left a comment
There was a problem hiding this comment.
A good start! WDYT about these touchups?
mark-wiemer
approved these changes
Jul 12, 2025
Member
|
@JoshuaKGoldberg I think we can merge this, the "compliance" check is failing but things look OK to me, it looks like it was a transient issue |
lennonnikolas
pushed a commit
to lennonnikolas/mocha
that referenced
this pull request
Jan 24, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes: #5396
PR Checklist
status: accepting prsOverview
The fix landed in node js main nodejs/node#58957 I belive we now should update the ESM support section of the documentation since this error has been affecting even node LTS. I took the liberty to guess the next node.js version, shouldn't matter if they skip the 24.4.1 patch straight to a new minor, the point will still stand.
I was intentionally vague in the problem description and proposed workaround, and left a link to the original issue so if the person is curious to learn more / understand how the fix works. I want to optimize for the quick answers crowd, the curious crowd can delight itself reading the original issue.