client: minor cleanups, refactors - #53509
Open
thaJeztah wants to merge 5 commits into
Open
Conversation
This allows more easily constructing a struct. Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
Make `body` the last argument, so that requests can be inlined on call-sites. Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
Use []plugin.Privilege for internal plugin install and upgrade helpers instead of the exported plugin.Privileges type. The latter primarily exists to implement sort.Interface, which these callers do not use. Keep plugin.Privileges at the public API boundary, where it remains part of AcceptPermissionsFunc's signature. Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
thaJeztah
force-pushed
the
client_refactor
branch
from
August 29, 2026 12:14
41ca29e to
53a8d14
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
client: minor cleanups, refactors
client: add valueOrZero utility
This allows more easily constructing a struct.
client: simplify normalizeCapabilities
client: add normalizeHostConfig utility
client: request: use consistent order or arguments
Make
bodythe last argument, so that requests can be inlined on call-sites.client: use slice type for plugin privileges internally
Use []plugin.Privilege for internal plugin install and upgrade helpers instead
of the exported plugin.Privileges type.
The latter primarily exists to implement sort.Interface, which these callers
do not use. Keep plugin.Privileges at the public API boundary, where it remains
part of AcceptPermissionsFunc's signature.
Release notes (optional)
A picture of a cute animal (not mandatory but encouraged)