Array implementation#2
Merged
Merged
Conversation
Member
Author
|
@mljs/collaborators this is only the array implementation, the idea is to extend it to matrix but for now I prefer to merge it now and see the rest later, I'm even thinking to publish in npm in order to use it for Savitsky-Golay and other ML packages |
Member
|
Can you put the whole output array in the tests ? it('Default test', function () {
var data = [1, 2, 3, 4];
var model = padArray(data);
model.should.eql([0, 1, 2, 3, 4, 0]);
}); |
Member
There was a problem hiding this comment.
may be good to specify that it doesn't change the input array and returns a new one
Member
|
made a few comments but looks good ! |
Member
|
👍 thank you! |
Member
Author
|
no man thanks to you, the question is should I publish it now to NPM and put it in ML or should I wait until I finish the matrix part? |
Member
|
I think it should be published without waiting for Matrix |
Member
|
I agree |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Work on progress