Added default arguments transpilation #9
Merged
Conversation
Contributor
Author
|
Waiting forward your approvals, guys, thank you! |
Member
|
I'm ok with that @targos should we keep the CJS build as well? |
Member
|
I think we need to keep a cjs build for Node? |
Contributor
Author
|
Will fix that, back soon! |
stropitek
requested changes
Nov 9, 2018
Member
stropitek
left a comment
There was a problem hiding this comment.
@glebmachine can you create 2 builds? One to commonjs in lib and one to es6 modules in a new directory called lib-es6?
Contributor
Author
|
@stropitek Done! |
Contributor
Author
|
I will be very appreciated if you accept the request today. I have release date today( |
Member
|
two more things:
Thank you! |
Member
|
I'm working on it |
Member
|
I pushed a change to
|
Contributor
Author
|
Thank you guys! |
Member
|
@stropitek can you merge (squash) and release please? |
Member
|
yep! |
Member
|
I have published the packages |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix of #8