docs: fix broken link to highlight.js demo page#4124
Draft
adv0r wants to merge 1 commit into
Draft
Conversation
The demo page has moved from /static/demo/ to /demo. The old URL now redirects to https://highlightjs.org/not-a-cdn which is unhelpful documentation. Reported in mkdocs#4095.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #4095
What
Replace the broken link to the highlight.js demo page in
docs/user-guide/choosing-your-theme.mdwith the current URL.https://highlightjs.org/static/demo/— now 301-redirects tohttps://highlightjs.org/not-a-cdn, which is unhelpful as documentation.https://highlightjs.org/demo— returns HTTP 200 and shows the live demo page.Why
Issue #4095 reports that the link referenced in the
hljs_styledocumentation has been broken since around August 2023 when highlightjs.org changed routes. The fix is a single-line URL update.How verified
Maintainer note
Feel free to close this with zero ceremony if the URL choice is wrong — it's a one-liner.