Fix dropdown submenu arrow invisible in non-hovered state (#3909)#4103
Open
armorbreak001 wants to merge 1 commit into
Open
Fix dropdown submenu arrow invisible in non-hovered state (#3909)#4103armorbreak001 wants to merge 1 commit into
armorbreak001 wants to merge 1 commit into
Conversation
The .dropdown-submenu > a::after rule used --bs-dropdown-link-active-color (which resolves to white on the default theme) for the border-left-color, making the submenu arrow invisible against a white background. Use --bs-dropdown-link-color instead so the arrow is visible by default, while keeping --bs-dropdown-link-active-color for the hover state. Fixes mkdocs#3909.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The CSS rule for
.dropdown-submenu > a::afteruses--bs-dropdown-link-active-color(which resolves to#fff/white on the default theme) for the submenu arrow'sborder-left-color. This makes the dropdown arrow invisible against a white background in non-hovered state — it only appears on hover because the hover rule correctly sets a visible color.Change
Before:
border-left-color: var(--bs-dropdown-link-active-color);(white → invisible)After:
border-left-color: var(--bs-dropdown-link-color);(gray → visible)The hover state (
.dropdown-submenu:hover > a::after) still uses--bs-dropdown-link-active-colorunchanged, so hover behavior is preserved.Context