Validate mitmweb flow filters on the backend - #8331
Open
lups2000 wants to merge 7 commits into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR moves mitmweb flow-filter validation (search/highlight/intercept) from the frontend to the backend, making
mitmproxy.flowfilterthe single source of truth for filter parsing.This adds a
GET /filter/validate?expression=...endpoint that returns either the parsed filter description or a validation error.The filter input now:
The obsolete frontend flow-filter parser (
filt.jsandfilt.peg) has been removed.Note
For a valid expression,
flowfilter.parse()is called twice: once by the validation endpoint and again when the filter is applied by Search, Highlight, or Intercept.This is intentional. The validation request and the operation applying the filter are independent, and the second parse keeps the existing backend paths authoritative without sharing parser objects or introducing a cache. The additional cost should be negligible.
It closes also: #8239
Checklist