build(deps): remove unused msgpack dependency - #8319
Merged
Conversation
Contributor
|
Hi! I'm I would like to apply some automated changes to this pull request, but it looks like I don't have the necessary permissions to do so. To get this pull request into a mergeable state, please do one of the following two things:
|
The msgpack contentview was rewritten in Rust and moved to mitmproxy_rs in mitmproxy#7623, which deleted the only import of the msgpack package. The pyproject entry survived, and the dependency-bump automation has been dutifully maintaining the dead dependency ever since, most recently resolving msgpack 1.1.2 in uv.lock. Dropping it removes a C-extension wheel from every install, and users lose nothing because the Rust contentview still provides msgpack rendering. Discovered using `pyproject-udeps` [[1]]. [1]: https://github.com/lukehsiao/pyproject-udeps Fixes: d0a35dc ("introduce new contentview API (mitmproxy#7623)")
13 tasks
nixos-cuda-channel-updater Bot
pushed a commit
to nixos-cuda/nixpkgs
that referenced
this pull request
Aug 4, 2026
MsgPack rendering has been provided by mitmproxy-rs since mitmproxy 12, so the Python msgpack dependency is unused. Declare msgpack directly in mitmproxy2swagger, which still requires it. mitmproxy/mitmproxy#8319 Assisted-by: OpenAI Codex (gpt-5.6-sol-xhigh)
norpie
pushed a commit
to norpie/nixpkgs
that referenced
this pull request
Aug 6, 2026
MsgPack rendering has been provided by mitmproxy-rs since mitmproxy 12, so the Python msgpack dependency is unused. Declare msgpack directly in mitmproxy2swagger, which still requires it. mitmproxy/mitmproxy#8319 Assisted-by: OpenAI Codex (gpt-5.6-sol-xhigh)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
The msgpack contentview was rewritten in Rust and moved to mitmproxy_rs in #7623, which deleted the only import of the msgpack package. The pyproject entry survived, and the dependency-bump automation has been dutifully maintaining the dead dependency ever since, most recently resolving msgpack 1.1.2 in uv.lock. Dropping it removes a C-extension wheel from every install, and users lose nothing because the Rust contentview still provides msgpack rendering.
Discovered using
pyproject-udeps[1].Fixes: d0a35dc ("introduce new contentview API (#7623)")
Checklist