Skip to content

build(deps): remove unused msgpack dependency - #8319

Merged
mhils merged 1 commit into
mitmproxy:mainfrom
lukehsiao-forks:main
Jul 14, 2026
Merged

build(deps): remove unused msgpack dependency#8319
mhils merged 1 commit into
mitmproxy:mainfrom
lukehsiao-forks:main

Conversation

@lukehsiao

@lukehsiao lukehsiao commented Jul 12, 2026

Copy link
Copy Markdown
Contributor

Description

The msgpack contentview was rewritten in Rust and moved to mitmproxy_rs in #7623, which deleted the only import of the msgpack package. The pyproject entry survived, and the dependency-bump automation has been dutifully maintaining the dead dependency ever since, most recently resolving msgpack 1.1.2 in uv.lock. Dropping it removes a C-extension wheel from every install, and users lose nothing because the Rust contentview still provides msgpack rendering.

Discovered using pyproject-udeps [1].

Fixes: d0a35dc ("introduce new contentview API (#7623)")

Checklist

  • I have updated tests where applicable.
  • I have added an entry to the CHANGELOG.

@autofix-ci

autofix-ci Bot commented Jul 12, 2026

Copy link
Copy Markdown
Contributor

Hi! I'm autofix logoautofix.ci, a bot that automatically fixes trivial issues such as code formatting in pull requests.

I would like to apply some automated changes to this pull request, but it looks like I don't have the necessary permissions to do so. To get this pull request into a mergeable state, please do one of the following two things:

  1. Allow edits by maintainers for your pull request, and then re-trigger CI (for example by pushing a new commit).
  2. Manually fix the issues identified for your pull request (see the GitHub Actions output for details on what I would like to change).

The msgpack contentview was rewritten in Rust and moved to mitmproxy_rs
in mitmproxy#7623, which deleted the only import of the msgpack package. The
pyproject entry survived, and the dependency-bump automation has been
dutifully maintaining the dead dependency ever since, most recently
resolving msgpack 1.1.2 in uv.lock. Dropping it removes a C-extension
wheel from every install, and users lose nothing because the Rust
contentview still provides msgpack rendering.

Discovered using `pyproject-udeps` [[1]].

[1]: https://github.com/lukehsiao/pyproject-udeps

Fixes: d0a35dc ("introduce new contentview API (mitmproxy#7623)")

@mhils mhils left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for catching this! 🍰

@mhils
mhils merged commit a138148 into mitmproxy:main Jul 14, 2026
28 checks passed
nixos-cuda-channel-updater Bot pushed a commit to nixos-cuda/nixpkgs that referenced this pull request Aug 4, 2026
MsgPack rendering has been provided by mitmproxy-rs since mitmproxy 12, so the Python msgpack dependency is unused. Declare msgpack directly in mitmproxy2swagger, which still requires it.

mitmproxy/mitmproxy#8319

Assisted-by: OpenAI Codex (gpt-5.6-sol-xhigh)
norpie pushed a commit to norpie/nixpkgs that referenced this pull request Aug 6, 2026
MsgPack rendering has been provided by mitmproxy-rs since mitmproxy 12, so the Python msgpack dependency is unused. Declare msgpack directly in mitmproxy2swagger, which still requires it.

mitmproxy/mitmproxy#8319

Assisted-by: OpenAI Codex (gpt-5.6-sol-xhigh)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants