Add individual exit codes for different error conditions#8129
Open
kovan wants to merge 2 commits intomitmproxy:mainfrom
Open
Add individual exit codes for different error conditions#8129kovan wants to merge 2 commits intomitmproxy:mainfrom
kovan wants to merge 2 commits intomitmproxy:mainfrom
Conversation
Replace all sys.exit(1) calls with specific exit codes so that parent processes can distinguish why mitmproxy exited. Exit codes: - 10: startup error (addon load failure, etc.) - 20: no TTY (console requires interactive shell) - 30: invalid arguments (unrecognized CLI flags) - 31: invalid options (bad --set values) - 40: cannot print (stdout broken) - 41: cannot write to file (disk full, etc.) Fixes mitmproxy#5696
Author
|
Valid concern. Well-written shell scripts already check for non-zero ( |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
sys.exit(1)calls with specific exit codes so parent processes can distinguish failure reasonsmitmproxy/utils/exit_codes.pydefining grouped exit codes:10— startup error (addon load failure, etc.)20— no TTY (console requires interactive shell)30— invalid arguments (unrecognized CLI flags)31— invalid options (bad--setvalues)40— cannot print (stdout broken)41— cannot write to file (disk full, etc.)Picks up from #5133 and #5882.
Fixes #5696
Test plan
test_exit_codes.py— exit codes are distinct, SUCCESS is 0test_errorcheck.py— startup errors exit with STARTUP_ERRORtest_termlog.py— print failure exits with CANNOT_PRINTtest_save.py— write failure exits with CANNOT_WRITE_TO_FILEtest_main.py— bad flags exit with INVALID_ARGS, bad options exit with INVALID_OPTIONS