fix: show helpful hint on WireGuard port conflicts#8098
Open
lweyrich1 wants to merge 1 commit intomitmproxy:mainfrom
Open
fix: show helpful hint on WireGuard port conflicts#8098lweyrich1 wants to merge 1 commit intomitmproxy:mainfrom
lweyrich1 wants to merge 1 commit intomitmproxy:mainfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #7650
Problem
WireGuard mode can fail to start with an "address already in use" error, but the message lacks the usual hint suggesting to pick a different port.
Solution
Extend the listener startup error handling so that WireGuard port-conflict exceptions (including non-OSError exceptions from the Rust backend) get wrapped into an OSError with the same helpful hint text used in other modes.
Testing
Added a regression test for the WireGuard port-conflict case.