Migrate from Genshi to defusedxml - #29
Merged
Merged
Conversation
* Add `defusedxml` to `install_requires`. Genshi was never listed, although it was only a requirement for building sdist. * Removed support for copying comments from CLDR XML. This would be difficult without a DOM parser, but the source file contains a local DTD reference which is banned in defusedxml. * Switch `create_win32tz_map` to a mostly-functional processing model, by `yield`ing earlier, instead of building complete dicts and `yield`ing after-the-fact. This causes output to be no longer sorted alphabetically. * Move special handling of `territory=001` into `create_win32tz_map`. Tested that generated content is identical, although the ordering will differ. Google-internal bug: 160436149
|
Thanks for opening this issue! I have applied any relevant labels. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Migrate from Genshi to defusedxml in update_win32tz_map.py:
Add
defusedxmltoinstall_requires. Genshi was never listed, althoughit was only a requirement for building sdist.
Removed support for copying comments from CLDR XML. This would be
difficult without a DOM parser, but the source file contains a local DTD
reference which is banned in defusedxml.
Switch
create_win32tz_mapto a mostly-functional processing model, byyielding earlier, instead of building complete dicts andyieldingafter-the-fact. This causes output to be no longer sorted alphabetically.
Move special handling of
territory=001intocreate_win32tz_map.Tested that generated content is identical, although the ordering will
differ.
Google-internal bug: 160436149