Skip to content

Code review: real-postfix #3

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
dehnert wants to merge 29 commits into
base: master
Choose a base branch
from
Draft

Code review: real-postfix #3

Changes from 1 commit
Commits
Show all changes
29 commits
Select commit Hold shift + click to select a range
ffe8bf6
Configure Postfix
quentinmit May 23, 2019
de4437e
Make /etc/scripts
quentinmit May 23, 2019
0c88576
Enable postfix
quentinmit May 23, 2019
579ff3c
Only accept mail on some VIPs
quentinmit May 23, 2019
cda3e5b
Install Postfix LDAP plugin
quentinmit May 23, 2019
7368b54
Use non-deprecated way to specify multiple packages
quentinmit May 23, 2019
f0f5272
Specify now-required smtpd_relay_restrictions
quentinmit May 23, 2019
f35bd7f
Configure Postfix with variable LDAP server
quentinmit May 24, 2019
05f8473
Reload postfix when config changes
quentinmit May 24, 2019
003949f
Install procmail
quentinmit May 25, 2019
53968ae
Install scripts's version of /etc/aliases
quentinmit May 29, 2019
e4eedf1
Delay postfix startup until network is online
quentinmit May 29, 2019
39ec12c
Create postfix unit override directory
quentinmit May 29, 2019
fa65200
Install and run Spamassassin
quentinmit May 29, 2019
c2a11ac
Configure spamass-milter
quentinmit May 29, 2019
a055fa1
Configure spamassassin
quentinmit May 29, 2019
fa72caa
Section null must be specified explicitly
quentinmit May 29, 2019
6c72056
Install prune-mailq
quentinmit Jun 24, 2019
e17d0e5
Generate postfix virtual_alias_domains from vips
quentinmit Jul 20, 2019
f532d23
Incoming mail blocks are now in LDAP
quentinmit Sep 5, 2019
c599ee6
authorized_submit_users is now in LDAP
quentinmit Sep 5, 2019
f7053d5
Install a bunch of packages from F20 on F30
quentinmit Dec 20, 2019
a7b99f9
Updating Postfix conf to forward messages to other server if current …
jkoppel Feb 1, 2020
ca1cf48
Only bind the VIPs for the current codename
quentinmit Feb 1, 2020
492fbb0
Adding transport-maps-ldap.cf to template list
jkoppel Feb 1, 2020
89eb801
Disable virtual_alias_maps for vhosts on another pool. Otherwise the …
quentinmit Feb 1, 2020
17af442
Make other pools into relay domains
quentinmit Feb 1, 2020
6d28907
cleanup checks virtual_alias_maps before both relay_domains and trans…
quentinmit Feb 1, 2020
8af2d41
Route mail for user@scripts.mit.edu based on user.scripts.mit.edu's pool
quentinmit Feb 5, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Disable virtual_alias_maps for vhosts on another pool. Otherwise the … 
…rewrite -> @scripts.mit.edu happens before transport_maps.
  • Loading branch information
@quentinmit @dehnert
quentinmit authored and dehnert committed Dec 11, 2020
commit 89eb8018fb3ee61d564bf5586640e0600c8f2c57
2 changes: 1 addition & 1 deletion ansible/roles/real-postfix/templates/postfix/virtual-alias-maps-ldap.cf.j2
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,7 @@

server_host = {{ ldap_server }}
search_base = ou=VirtualHosts,dc=scripts,dc=mit,dc=edu
query_filter = (&(objectClass=scriptsVhost)(|(scriptsVhostName=%d)(scriptsVhostAlias=%d))(!(scriptsVhostName=scripts.mit.edu)))
query_filter = (&(objectClass=scriptsVhost)(|(scriptsVhostName=%d)(scriptsVhostAlias=%d))(!(scriptsVhostName=scripts.mit.edu))(|{% for ip in ansible_all_ipv4_addresses %}(scriptsVhostPoolIPv4={{ip}}){% endfor %}))
Copy link
Copy Markdown
Contributor Author

@dehnert dehnert Dec 12, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I fear my ongoing fondness for line breaks is once more flaring up.

Copy link
Copy Markdown
Contributor Author

@dehnert dehnert Dec 12, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm also going to observe that I find it slightly disconcerting that Postfix uses %s and %d since I'm pretty used to printf, so %d "should" be an int, but this is obviously not your fault (and if I were more used to, say, strftime and less used to printf it'd probably feel less weird).

result_attribute = uid
result_format = %s+%U
bind = no
Expand Down