Repository navigation
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #8471 +/- ##
========================================
Coverage 99.66% 99.66%
========================================
Files 293 293
Lines 32172 32185 +13
Branches 9094 8686 -408
========================================
+ Hits 32065 32078 +13
Misses 103 103
Partials 4 4 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
$notis a query operator, so a few places treated{ $not: { name: 'blue' } }under a collection like{ $in: [...] }, a condition on the relation itself, and not on the target entity.For an M:N property, this joined only the pivot table and queried
pivot.name, which fails with "no such column". InpopulateWhere, the select-in loader moved the$notunder the target PK ({ id: { $not: { title: 'B' } } }), and that crashed injoinReference. With the joined strategy, the$notwas dropped from the join'sonclause, so the filter matched the opposite rows.Now a
$notthat wraps entity conditions is handled like those conditions: the target entity gets joined, the loader keeps it on the target entity, and the joined strategy adds the whole$notto the join it targets.Fixes #8468