Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## next #7404 +/- ##
========================================
Coverage 99.64% 99.64%
========================================
Files 262 262
Lines 26080 26084 +4
Branches 7207 6756 -451
========================================
+ Hits 25987 25991 +4
Misses 88 88
Partials 5 5 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
280b519 to
d48d769
Compare
…tity` uses `extends` Previously, only `BaseEntity` was handled as a special case when generating classes for `defineEntity` without an explicit `class` option. Now the auto-generated class extends the parent class regardless of whether `extends` is a class constructor or an EntitySchema, so property initializers from the base class run automatically via `super()`. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
d48d769 to
713a4e4
Compare
B4nan
added a commit
that referenced
this pull request
Apr 19, 2026
…ity extends (#7404) ## Summary - When `defineEntity` is used without an explicit `class` option and with `extends` pointing to another schema or class, the auto-generated class now extends the parent class at the JS level - Previously only `BaseEntity` was special-cased — any other `extends` value produced a bare `class {}` with no prototype chain, so property initializers from the base class didn't run via `super()` - Uses duck-typing to resolve `EntitySchema` parent classes (runtime import of `EntitySchema` in `typings.ts` is blocked by circular dependency) - Added docs in `define-entity.md` (primary), `inheritance-mapping.md`, and `entity-constructors.md` 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-authored-by: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
B4nan
added a commit
that referenced
this pull request
Apr 20, 2026
…ity extends (#7404) ## Summary - When `defineEntity` is used without an explicit `class` option and with `extends` pointing to another schema or class, the auto-generated class now extends the parent class at the JS level - Previously only `BaseEntity` was special-cased — any other `extends` value produced a bare `class {}` with no prototype chain, so property initializers from the base class didn't run via `super()` - Uses duck-typing to resolve `EntitySchema` parent classes (runtime import of `EntitySchema` in `typings.ts` is blocked by circular dependency) - Added docs in `define-entity.md` (primary), `inheritance-mapping.md`, and `entity-constructors.md` 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-authored-by: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
defineEntityis used without an explicitclassoption and withextendspointing to another schema or class, the auto-generated class now extends the parent class at the JS levelBaseEntitywas special-cased — any otherextendsvalue produced a bareclass {}with no prototype chain, so property initializers from the base class didn't run viasuper()EntitySchemaparent classes (runtime import ofEntitySchemaintypings.tsis blocked by circular dependency)define-entity.md(primary),inheritance-mapping.md, andentity-constructors.md🤖 Generated with Claude Code