feat(core): support array option on scalar properties#7378
Merged
Conversation
cd5ec69 to
565981c
Compare
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## next #7378 +/- ##
========================================
Coverage 99.64% 99.64%
========================================
Files 262 262
Lines 26080 26105 +25
Branches 7207 7061 -146
========================================
+ Hits 25987 26012 +25
Misses 88 88
Partials 5 5 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
DASPRiD
reviewed
Mar 22, 2026
565981c to
3b9b30a
Compare
b2b2968 to
e29a8f1
Compare
Contributor
|
LGTM, definitely better than my implementation, I agree. I also like that this additionally supports other database engines this way. Good job! 👍 |
Contributor
|
Whats the diff than having |
Member
Author
|
|
Contributor
True true. Now i see, nice improvement! |
Contributor
|
For custom types, it requires to define it like this: |
Member
Author
|
Both should work, will adjust some tests to use that approach too. |
64de58d to
025767f
Compare
Allow `p.integer().array()`, `p.type(new CustomType()).array()`, and
`@Property({ type: IntegerType, array: true })` for scalar properties.
During discovery, when `array: true` is set on a scalar with a custom
type, the type is automatically wrapped in an `ArrayType` that delegates
element conversion to the inner type. The column type is inferred as
`innerType.getColumnType() + '[]'` on platforms with native array
support (postgres), or falls back to the platform's default array
storage type (e.g. `text`) on others.
Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
025767f to
02899d3
Compare
Contributor
@B4nan does it work the way I posted above ? Did you figure out or shall we test and see ? |
Member
Author
|
I dont remember, give it a try :) |
B4nan
added a commit
that referenced
this pull request
Apr 19, 2026
## Summary
- Expose `array: true` on `PropertyOptions` so scalar properties can use
it via `@Property({ type: IntegerType, array: true })` or
`p.integer().array()`
- During discovery, when `array: true` is set on a scalar with a custom
type, the type is automatically wrapped in an `ArrayType` that delegates
element conversion to the inner type's
`convertToJSValue`/`convertToDatabaseValue`
- Column type is inferred as `innerType.getColumnType() + '[]'` (e.g.
`int[]`, `text[]`, `numeric(10,2)[]`)
Relates to #7363 — provides a simpler alternative without introducing a
new type class.
### Usage
```ts
// defineEntity
integers: p.integer().array()
decimals: p.decimal('number').array().precision(10).scale(2)
custom: p.type(new PlainTimeType()).array()
// decorators
@Property({ type: IntegerType, array: true })
integers!: number[];
```
🤖 Generated with [Claude Code](https://claude.com/claude-code)
Co-authored-by: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
B4nan
added a commit
that referenced
this pull request
Apr 20, 2026
## Summary
- Expose `array: true` on `PropertyOptions` so scalar properties can use
it via `@Property({ type: IntegerType, array: true })` or
`p.integer().array()`
- During discovery, when `array: true` is set on a scalar with a custom
type, the type is automatically wrapped in an `ArrayType` that delegates
element conversion to the inner type's
`convertToJSValue`/`convertToDatabaseValue`
- Column type is inferred as `innerType.getColumnType() + '[]'` (e.g.
`int[]`, `text[]`, `numeric(10,2)[]`)
Relates to #7363 — provides a simpler alternative without introducing a
new type class.
### Usage
```ts
// defineEntity
integers: p.integer().array()
decimals: p.decimal('number').array().precision(10).scale(2)
custom: p.type(new PlainTimeType()).array()
// decorators
@Property({ type: IntegerType, array: true })
integers!: number[];
```
🤖 Generated with [Claude Code](https://claude.com/claude-code)
Co-authored-by: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
array: trueonPropertyOptionsso scalar properties can use it via@Property({ type: IntegerType, array: true })orp.integer().array()array: trueis set on a scalar with a custom type, the type is automatically wrapped in anArrayTypethat delegates element conversion to the inner type'sconvertToJSValue/convertToDatabaseValueinnerType.getColumnType() + '[]'(e.g.int[],text[],numeric(10,2)[])Relates to #7363 — provides a simpler alternative without introducing a new type class.
Usage
🤖 Generated with Claude Code