Skip to content

redis manager, verbose error logging#1479

Merged
miguelgrinberg merged 1 commit into
miguelgrinberg:mainfrom
Eugnee:main
Aug 24, 2025
Merged

redis manager, verbose error logging#1479
miguelgrinberg merged 1 commit into
miguelgrinberg:mainfrom
Eugnee:main

Conversation

@Eugnee

@Eugnee Eugnee commented Jul 28, 2025

Copy link
Copy Markdown
Contributor

Sometimes it's very useful to see exact error from redis in logs

@miguelgrinberg

Copy link
Copy Markdown
Owner

Can we instead print the exception message? The stack trace here is not very useful. My concern is that for every person who wants more verbosity in the logs there's going to be another that complains that the logs are too verbose after this change is made.

@Eugnee

Eugnee commented Jul 28, 2025

Copy link
Copy Markdown
Contributor Author

I usually prefer full stack trace, but you probably right.
In this case, I guess something like str(exc) should be fine.

Sometimes it's very useful to see exact error from redis in logs
@Eugnee

Eugnee commented Aug 19, 2025

Copy link
Copy Markdown
Contributor Author

@miguelgrinberg Hi, how are you?
It's okay now, or you see it differently?

@miguelgrinberg miguelgrinberg merged commit b01b197 into miguelgrinberg:main Aug 24, 2025
21 of 22 checks passed
@miguelgrinberg

Copy link
Copy Markdown
Owner

LGTM. Thanks!

@phi-friday phi-friday mentioned this pull request Aug 29, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants