Skip to content

bugfix/linting #635

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
baywet merged 7 commits into from
Jul 12, 2024
Merged

bugfix/linting #635

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
f3d234f
chore: linting removing unused import
baywet Jul 12, 2024
857ad99
fix: fixes exception configuration in pylint
baywet Jul 12, 2024
d7c0e1b
fix: suppressed linting error message that fails dependencies
baywet Jul 12, 2024
b56cc8d
fix: linting fix import ordering
baywet Jul 12, 2024
7ad013e
fix: adds missing whitespace for suppressions
baywet Jul 12, 2024
b6c1d29
fix: moves attributes suppression to class definition
baywet Jul 12, 2024
f39f0b9
fix: linting missing line
baywet Jul 12, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions .pylintrc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -513,5 +513,5 @@ preferred-modules=

# Exceptions that will emit a warning when being caught. Defaults to
# "BaseException, Exception".
overgeneral-exceptions=BaseException,
Exception
overgeneral-exceptions=builtins.BaseException,
builtins.Exception
2 changes: 1 addition & 1 deletion src/msgraph_core/base_graph_request_adapter.py
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,3 +1,4 @@
from typing import Optional
import httpx
from kiota_abstractions.authentication import AuthenticationProvider
from kiota_abstractions.serialization import (
Expand All @@ -7,7 +8,6 @@
SerializationWriterFactoryRegistry,
)
from kiota_http.httpx_request_adapter import HttpxRequestAdapter
from typing import Optional

from .graph_client_factory import GraphClientFactory

Expand Down
5 changes: 3 additions & 2 deletions src/msgraph_core/tasks/large_file_upload.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,9 +14,10 @@

from kiota_abstractions.request_adapter import RequestAdapter

from msgraph_core.models import LargeFileUploadSession, UploadResult, UploadSessionDataHolder # check imports
from msgraph_core.models import LargeFileUploadSession, UploadResult # check imports


# pylint: disable=too-many-instance-attributes
class LargeFileUploadTask:

def __init__(
Expand Down Expand Up @@ -128,7 +129,7 @@ async def upload(self, after_chunk_upload: Optional[Callable] = None):
self.next_range = next_range[0] + "-"
process_next = await self.next_chunk(self.stream)

except Exception as error:
except Exception as error: #pylint: disable=broad-except
logging.error("Error uploading chunk %s", error)
finally:
self.chunks -= 1
Expand Down