fix(uploader): TypeError between offset-native and offset-aware datetimes#1082
Open
mango-cube wants to merge 1 commit into
Open
fix(uploader): TypeError between offset-native and offset-aware datetimes#1082mango-cube wants to merge 1 commit into
mango-cube wants to merge 1 commit into
Conversation
|
There was a problem hiding this comment.
Pull request overview
Fixes a TypeError in LargeFileUploadTask.upload_session_expired caused by subtracting offset-aware and offset-naive datetime values when validating whether an upload session has expired.
Changes:
- Forces
expiration_date_timedatetimes to be treated as UTC to avoid naive/aware subtraction errors.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Comment on lines
75
to
80
| if isinstance(expiry, str): | ||
| then = datetime.strptime(expiry, "%Y-%m-%dT%H:%M:%S") | ||
| elif isinstance(expiry, datetime): | ||
| then = expiry | ||
| then = expiry.replace(tzinfo=timezone.utc) | ||
| else: | ||
| raise ValueError("Expiry is not a string or datetime") |
Comment on lines
74
to
+78
| raise ValueError("Expiry is None") | ||
| if isinstance(expiry, str): | ||
| then = datetime.strptime(expiry, "%Y-%m-%dT%H:%M:%S") | ||
| elif isinstance(expiry, datetime): | ||
| then = expiry | ||
| then = expiry.replace(tzinfo=timezone.utc) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The error: