Skip to content

refactor: update getTokenOptions name and add missing import to docs#939

Merged
nikithauc merged 2 commits into
microsoftgraph:devfrom
laudebugs:patch-1
Aug 29, 2022
Merged

refactor: update getTokenOptions name and add missing import to docs#939
nikithauc merged 2 commits into
microsoftgraph:devfrom
laudebugs:patch-1

Conversation

@laudebugs

@laudebugs laudebugs commented Aug 29, 2022

Copy link
Copy Markdown
Contributor

A similar PR may already be submitted! Please search among the Pull request before creating one.

Thanks for submitting a pull request! Please provide enough information so that others can review your pull request.

NOTE: PR's will be accepted only in case of appropriate information is provided below

Summary

  • Change getTokenoptions to getTokenOptions - more accurate camel casing
  • Updated locations where TokenCredentialAuthenticationProviderOptions.getTokenOptions was used/refeferenced
  • Add missing import to javascript sdk example.

Motivation

When going through the docs, I encountered a missing import for the typescript example. As well, the getTokenOptions was not in accurate camel casing.

Test plan

N/A: No new tests added

Closing issues

N/A

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Makes changes to existing documentation

Checklist

  • I have read the CONTRIBUTING document.
  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@ghost

ghost commented Aug 29, 2022

Copy link
Copy Markdown

CLA assistant check
All CLA requirements met.

@nikithauc nikithauc enabled auto-merge (squash) August 29, 2022 17:15
@nikithauc

Copy link
Copy Markdown
Contributor

@laudebugs Thank you for your contribution!

@laudebugs laudebugs changed the title docs: add missing import refactor: update getTokenOptions name and add missing import to docs Aug 29, 2022
@nikithauc nikithauc merged commit 49971f6 into microsoftgraph:dev Aug 29, 2022
@laudebugs laudebugs deleted the patch-1 branch August 29, 2022 22:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants