Fix typing for select, expand, and orderby#59
Closed
forivall wants to merge 1 commit into
Closed
Conversation
|
|
Author
|
Hmm, one thing i thought about: if you want to ensure that arrays have at least one element (i disagree that that should be done, but that's neither here nor there), the workaround that I have to do is |
Contributor
|
@forivall Thank you for taking the time to open this pull request! I won't be able to get to this right away but we'll get this into the next update. |
Contributor
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I noticed that the typing for select defines a tuple type with a single item, and not an array type. This caused code such as
to fail typechecking with the message
This also fixes typechecking for supplying multiple arguments, where
c.api('/me').select('city', 'country').buildFullUrl()would get the messageExpected 1 arguments, but got 2.