Feat/configure release please#713
Merged
Merged
Conversation
205f136 to
4f1a310
Compare
4f1a310 to
a8af3b4
Compare
baywet
requested changes
May 21, 2024
baywet
left a comment
Member
There was a problem hiding this comment.
Thanks for starting on this. Rather than doing it partially, I'd prefer we have all the changes at once if we can.
baywet
requested changes
May 22, 2024
baywet
left a comment
Member
There was a problem hiding this comment.
Thanks for making the changes, only the contributing file remains to be updated at this point.
9 tasks
baywet
approved these changes
May 24, 2024
baywet
reviewed
May 24, 2024
| "release-type": "go", | ||
| "bump-minor-pre-major": true, | ||
| "bump-patch-for-minor-pre-major": true, | ||
| "include-component-in-tag": false, |
Member
There was a problem hiding this comment.
@rkodev we need the "include-v-in-tag" to be set to true, sorry for not caching that earlier.
https://github.com/googleapis/release-please/blob/656b9a9ad1ec77853d16ae1f40e63c4da1e12f0f/schemas/config.json#L81
https://github.com/microsoftgraph/msgraph-sdk-php/pull/1532/files#diff-c55d4dcb68c348b2c06d263819702fbce72eeeb35b662956d02049a5a18fcf2bR13
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Overview
Adds release please to current repo
Partially address #705