This repository was archived by the owner on Dec 23, 2021. It is now read-only.
Small Changes For Accessibility#310
Merged
Merged
Conversation
nasadigital
approved these changes
Apr 9, 2020
nasadigital
left a comment
There was a problem hiding this comment.
LGTM.
Just curious, would it have been feasible to run accessibility insights as part of the CI pipeline?
Contributor
Author
I'm not 100% sure. When I do it, it's a Windows Application and I run it many times with the simulator in different states and then manually look through the UI Automation Tree. It would be cool to add though. We could definitely look into it. |
xnkevinnguyen
approved these changes
Apr 9, 2020
Contributor
xnkevinnguyen
left a comment
There was a problem hiding this comment.
Awesome! Glad our extension is accessible!!!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description:
Accessibility Insights Test:
Everything after Document (in red) is what we added to VS Code. Everything else is VS Code, which we cannot change.
Type of change
Please delete options that are not relevant.
Limitations:
Please describe limitations of this PR
Testing:
Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration
Checklist:
npm run formatand passes the checks innpm run check