This repository was archived by the owner on Dec 23, 2021. It is now read-only.
Microbit Debugger Fix#292
Merged
Merged
Conversation
xnkevinnguyen
approved these changes
Apr 2, 2020
Contributor
xnkevinnguyen
left a comment
There was a problem hiding this comment.
LGTM! Thanks for fixing it
nasadigital
reviewed
Apr 2, 2020
| ) | ||
|
|
||
| sys.path.insert(0, abs_path_to_parent_dir) | ||
| # Insert absolute path to Micropython libraries for micro:bit into sys.path |
There was a problem hiding this comment.
I would put this comment above the line it's referring to (or maybe remove the line break on line 20).
Now it seems as if it's referring to the next three lines where we calculate the path.
nasadigital
reviewed
Apr 2, 2020
Comment on lines
-7
to
-8
| from adafruit_circuitplayground import express | ||
| from common import debugger_communication_client |
There was a problem hiding this comment.
Just curious, if we used relative paths would the tests use the correct library?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description:
Currently, the microbit does not respond to sensor/button input in debug mode.
This is because the handle to the microbit model instance is different in
debugger_communication_client.pycompared to everywhere else. Sincemicropythonandmicrobitare both packages (althoughmicrobitis inside of themicropythonpackage), instances imported asfrom microbit.__model.microbit_model import __mb as mbandfrom micropython.microbit.__model.microbit_model import __mb as mbdeal with two different instances ofmb. As a result, thembthat was getting an updated state was different than the one being referenced by the user code.Type of change
Testing:
Simple code using any sensors/buttons in DEBUG MODE such as this:
Checklist:
npm run formatand passes the checks innpm run check