You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
This repository was archived by the owner on Dec 23, 2021. It is now read-only.
Removed preview mode setting, so microbit commands show up regardless
If anyone has a better idea to remove it so that it is easy to add once again (for clue), please let me know
Type of change
Please delete options that are not relevant.
New feature (non-breaking change which adds functionality)
Limitations:
Please describe limitations of this PR
Testing:
Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration
Test A
Test B
Checklist:
My code follows the style guidelines of this project
My code has been formatted with npm run format and passes the checks in npm run check
I have performed a self-review of my own code
I have commented my code, particularly in hard-to-understand areas
I have made corresponding changes to the documentation
My changes generate no new warnings
Any dependent changes have been merged and published in downstream modules
The reason will be displayed to describe this comment to others. Learn more.
LGTM.
Are you sure you want to delete preview mode? If you add any new devices, I assume you would first offer them through the preview mode.
You would need to add everything back in that case, right?
LGTM.
Are you sure you want to delete preview mode? If you add any new devices, I assume you would first offer them through the preview mode.
You would need to add everything back in that case, right?
@nasadigital
Yeah, we would have to add everything back. I'm not sure what the best way to do this is. Maybe we can hold off on this until we decide on a release date for sure?
@nasadigital
Yeah, we would have to add everything back. I'm not sure what the best way to do this is. Maybe we can hold off on this until we decide on a release date for sure?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Labels
None yet
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
nasadigital
left a comment
AB#34122
Description:
Type of change
Please delete options that are not relevant.
Limitations:
Please describe limitations of this PR
Testing:
Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration
Checklist:
npm run formatand passes the checks innpm run check